lkml.org 
[lkml]   [2020]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 485/639] usb: host: xhci-hub: fix extra endianness conversion
    Date
    From: Ruslan Bilovol <ruslan.bilovol@gmail.com>

    [ Upstream commit 6269e4c76eacabaea0d0099200ae1a455768d208 ]

    Don't do extra cpu_to_le32 conversion for
    put_unaligned_le32 because it is already implemented
    in this function.

    Fixes sparse error:
    xhci-hub.c:1152:44: warning: incorrect type in argument 1 (different base types)
    xhci-hub.c:1152:44: expected unsigned int [usertype] val
    xhci-hub.c:1152:44: got restricted __le32 [usertype]

    Fixes: 395f540 "xhci: support new USB 3.1 hub request to get extended port status"
    Cc: Mathias Nyman <mathias.nyman@linux.intel.com>
    Signed-off-by: Ruslan Bilovol <ruslan.bilovol@gmail.com>
    Link: https://lore.kernel.org/r/1562501839-26522-1-git-send-email-ruslan.bilovol@gmail.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/host/xhci-hub.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/usb/host/xhci-hub.c b/drivers/usb/host/xhci-hub.c
    index 8f180bf7561a2..9772c0de59b7d 100644
    --- a/drivers/usb/host/xhci-hub.c
    +++ b/drivers/usb/host/xhci-hub.c
    @@ -1104,7 +1104,7 @@ int xhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,
    }
    port_li = readl(ports[wIndex]->addr + PORTLI);
    status = xhci_get_ext_port_status(temp, port_li);
    - put_unaligned_le32(cpu_to_le32(status), &buf[4]);
    + put_unaligned_le32(status, &buf[4]);
    }
    break;
    case SetPortFeature:
    --
    2.20.1


    \
     
     \ /
      Last update: 2020-01-24 12:28    [W:2.194 / U:0.440 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site