Messages in this thread |  | | From | Brendan Higgins <> | Date | Thu, 23 Jan 2020 14:15:13 -0800 | Subject | Re: [PATCH v1 1/7] pinctrl: equilibrium: add unspecified HAS_IOMEM dependency |
| |
Sorry for not getting to this before I went on vacation.
On Mon, Dec 16, 2019 at 2:39 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Wed, Dec 11, 2019 at 8:28 PM Brendan Higgins > <brendanhiggins@google.com> wrote: > > > Currently CONFIG_PINCTRL_EQUILIBRIUM=y implicitly depends on > > CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get > > the following build error: > > > > ld: drivers/pinctrl/pinctrl-equilibrium.o: in function `eqbr_pinctrl_probe': > > drivers/pinctrl/pinctrl-equilibrium.c:908: undefined reference to `devm_platform_ioremap_resource' > > ld: drivers/pinctrl/pinctrl-equilibrium.c:223: undefined reference to `devm_ioremap_resource' > > > > Fix the build error by adding the CONFIG_HAS_IOMEM=y dependency. > > > > Reported-by: Brendan Higgins <brendanhiggins@google.com> > > Signed-off-by: Brendan Higgins <brendanhiggins@google.com> > > Patch applied but I augmented it with the recently added > OF dependency so it now says: > depends on OF && HAS_IOMEM
Probably too late now to be helpful, but I can confirm that OF does NOT depend on HAS_IOMEM, so this patch was still needed.
Thanks regardless!
|  |