Messages in this thread |  | | From | Bartosz Golaszewski <> | Date | Thu, 23 Jan 2020 11:16:25 +0100 | Subject | Re: [PATCH v4 02/13] gpiolib: have a single place of calling set_config() |
| |
pon., 20 sty 2020 o 09:44 Geert Uytterhoeven <geert@linux-m68k.org> napisał(a): > > Hi Bartosz, > > On Tue, Dec 24, 2019 at 1:08 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > Instead of calling the gpiochip's set_config() callback directly and > > checking its existence every time - just add a new routine that performs > > this check internally. Call it in gpio_set_config() and > > gpiod_set_transitory(). Also call it in gpiod_set_debounce() and drop > > the check for chip->set() as it's irrelevant to this config option. > > > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> >
[snip!]
> > These two lines are not equivalent: the new code no longer uses the > packed value of mode and arg! > Hence this leads to subsequent cleanups in commits e5e42ad224a040f9 > ("gpiolib: remove set but not used variable 'config'") and d18fddff061d2796 > ("gpiolib: Remove duplicated function gpio_do_set_config()"). > > However, what was the purpose of the PIN_CONF_PACKED() translation? > Why is it no longer needed? >
Thanks for catching this. I was OoO for a couple days. I'll try to get through the mail today and address this as well.
Bartosz
|  |