lkml.org 
[lkml]   [2020]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 3/3] clk: qcom: Add modem clock controller driver for SC7180
Hi,

On Thu, Dec 26, 2019 at 8:43 PM Taniya Das <tdas@codeaurora.org> wrote:
>
> Add support for the modem clock controller found on SC7180
> based devices. This would allow modem drivers to probe and
> control their clocks.
>
> Signed-off-by: Taniya Das <tdas@codeaurora.org>
> ---
> drivers/clk/qcom/Kconfig | 9 +++++
> drivers/clk/qcom/Makefile | 1 +
> drivers/clk/qcom/gcc-sc7180.c | 70 ++++++++++++++++++++++++++++++++
> drivers/clk/qcom/mss-sc7180.c | 94 +++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 174 insertions(+)
> create mode 100644 drivers/clk/qcom/mss-sc7180.c
>
> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index 3b33ef1..5d4b6e5 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
> @@ -245,6 +245,15 @@ config SC_GCC_7180
> Say Y if you want to use peripheral devices such as UART, SPI,
> I2C, USB, UFS, SDCC, etc.
>
> +config SC_MSS_7180
> + tristate "SC7180 MSS Clock Controller"
> + select SC_GCC_7180
> + help
> + Support for the MSS clock controller on Qualcomm Technologies, Inc
> + SC7180 devices.
> + Say Y if you want to use the MSS branch clocks of the MSS clock
> + controller to reset the MSS subsystem.

I didn't review your whole patch, but I was skimming through things
and trying to figure out what the heck a "MSS" clock was for a while
before I finally thought to look at the commit message and figured out
that it probably means "modem subsystem". I assume you're going to
spin this patch somewhat soon. When you do, can you please expand the
"MSS" acronym somewhere in your KConfig description?

Thanks!

-Doug

\
 
 \ /
  Last update: 2020-01-22 22:30    [W:0.038 / U:3.824 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site