lkml.org 
[lkml]   [2020]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] net/mlx5e: Fix printk format warning
Hi,

On Mon, Dec 30, 2019 at 8:35 PM Saeed Mahameed
<saeedm@dev.mellanox.co.il> wrote:
>
> On Sat, Dec 21, 2019 at 1:19 PM Olof Johansson <olof@lixom.net> wrote:
> >
> > On Thu, Dec 19, 2019 at 6:07 PM Joe Perches <joe@perches.com> wrote:
> > >
> > > On Thu, 2019-12-19 at 16:15 -0800, Olof Johansson wrote:
> > > > Use "%zu" for size_t. Seen on ARM allmodconfig:
> > > []
> > > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/wq.c b/drivers/net/ethernet/mellanox/mlx5/core/wq.c
> > > []
> > > > @@ -89,7 +89,7 @@ void mlx5_wq_cyc_wqe_dump(struct mlx5_wq_cyc *wq, u16 ix, u8 nstrides)
> > > > len = nstrides << wq->fbc.log_stride;
> > > > wqe = mlx5_wq_cyc_get_wqe(wq, ix);
> > > >
> > > > - pr_info("WQE DUMP: WQ size %d WQ cur size %d, WQE index 0x%x, len: %ld\n",
> > > > + pr_info("WQE DUMP: WQ size %d WQ cur size %d, WQE index 0x%x, len: %zu\n",
> > > > mlx5_wq_cyc_get_size(wq), wq->cur_sz, ix, len);
> > > > print_hex_dump(KERN_WARNING, "", DUMP_PREFIX_OFFSET, 16, 1, wqe, len, false);
> > > > }
> > >
> > > One might expect these 2 outputs to be at the same KERN_<LEVEL> too.
> > > One is KERN_INFO the other KERN_WARNING
> >
> > Sure, but I'll leave that up to the driver maintainers to decide/fix
> > -- I'm just addressing the type warning here.
>
> Hi Olof, sorry for the delay, and thanks for the patch,
>
> I will apply this to net-next-mlx5 and will submit to net-next myself.
> we will fixup and address the warning level comment by Joe.

This seems to still be pending, and the merge window is soon here. Any
chance we can see it show up in linux-next soon?


Thanks,

-Olof

\
 
 \ /
  Last update: 2020-01-21 04:21    [W:0.063 / U:11.524 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site