lkml.org 
[lkml]   [2020]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/5] input: joystick: Add ADC attached joystick driver.
On Sat, Jan 11, 2020 at 11:54:40AM +0000, Jonathan Cameron wrote:
> On Sun, 5 Jan 2020 01:16:39 +0100
> Artur Rojek <contact@artur-rojek.eu> wrote:
>
> > Add a driver for joystick devices connected to ADC controllers
> > supporting the Industrial I/O subsystem.
> >
> > Signed-off-by: Artur Rojek <contact@artur-rojek.eu>
> > Tested-by: Paul Cercueil <paul@crapouillou.net>
>
> Looks pretty good, but I'd like to see a little more sanity checking
> on probe that the channels are in a format this driver can actually
> handle. Given we can check channel size and consistency etc early
> it would be better to fail to probe than just report error data later.

Artur,

From my POV it looks decent so as soon as you address Jonathan requests
you can add

Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

assuming you want it to be perged through IIO tree.

Thanks.

--
Dmitry

\
 
 \ /
  Last update: 2020-01-20 20:40    [W:0.050 / U:1.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site