Messages in this thread |  | | From | Michael Kelley <> | Subject | RE: [RFC PATCH V2 3/10] x86/Hyper-V/Balloon: Replace hot-add and balloon up works with a common work | Date | Mon, 20 Jan 2020 19:12:13 +0000 |
| |
From: Tianyu Lan <Tianyu.Lan@microsoft.com> Sent: Tuesday, January 7, 2020 5:10 AM > > The mem hot-remove operation and balloon down will be added > or moved into work context. Add a common work to handle > opeations of mem hot-add/remove and balloon up/down.
Let me suggest some improved wording for this commit message:
The Hyper-V balloon driver currently has separate work contexts for memory hot-add operations and for balloon up (i.e., remove memory from the guest) operations. Hot-remove is being added and must be done in a work context. And finally, balloon down is currently not done in a work context, but needs to move to a work context because of a Hyper-V bug that confuses balloon operations and hot-remove. Rather than add code for two additional work contexts, consolidate the current hot-add and balloon up operations onto a single work context. Subsequent patches will add hot-remove and balloon down to that same work context.
My assumption is that the consolidation into a single work context is just code simplification. If there's another reason, please describe it.
The code is this patch looks OK to me.
Michael
> > Signed-off-by: Tianyu Lan <Tianyu.Lan@microsoft.com> > --- > drivers/hv/hv_balloon.c | 86 ++++++++++++++++++++++++++++++------------------- > 1 file changed, 52 insertions(+), 34 deletions(-) >
|  |