Messages in this thread |  | | Date | Mon, 20 Jan 2020 11:54:27 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v4 02/13] gpiolib: have a single place of calling set_config() |
| |
On Mon, Jan 20, 2020 at 09:44:43AM +0100, Geert Uytterhoeven wrote: > On Tue, Dec 24, 2019 at 1:08 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > > > Instead of calling the gpiochip's set_config() callback directly and > > checking its existence every time - just add a new routine that performs > > this check internally. Call it in gpio_set_config() and > > gpiod_set_transitory(). Also call it in gpiod_set_debounce() and drop > > the check for chip->set() as it's irrelevant to this config option.
...
> > config = PIN_CONF_PACKED(mode, arg); > > - return gc->set_config ? gc->set_config(gc, offset, config) : -ENOTSUPP; > > + return gpio_do_set_config(gc, offset, mode); > > These two lines are not equivalent: the new code no longer uses the > packed value of mode and arg!
Good catch! It's a regression (pin control drivers expects arg to be 1 in case it has been called thru GPIO framework to set "default" values in terms of certain driver) and below mentioned commits must be reverted. This one seems has a typo which must be fixed.
> Hence this leads to subsequent cleanups in commits e5e42ad224a040f9 > ("gpiolib: remove set but not used variable 'config'") and d18fddff061d2796 > ("gpiolib: Remove duplicated function gpio_do_set_config()").
> However, what was the purpose of the PIN_CONF_PACKED() translation? > Why is it no longer needed?
-- With Best Regards, Andy Shevchenko
|  |