lkml.org 
[lkml]   [2020]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 081/114] filldir[64]: remove WARN_ON_ONCE() for bad directory entries
    Date
    From: Linus Torvalds <torvalds@linux-foundation.org>

    commit b9959c7a347d6adbb558fba7e36e9fef3cba3b07 upstream.

    This was always meant to be a temporary thing, just for testing and to
    see if it actually ever triggered.

    The only thing that reported it was syzbot doing disk image fuzzing, and
    then that warning is expected. So let's just remove it before -rc4,
    because the extra sanity testing should probably go to -stable, but we
    don't want the warning to do so.

    Reported-by: syzbot+3031f712c7ad5dd4d926@syzkaller.appspotmail.com
    Fixes: 8a23eb804ca4 ("Make filldir[64]() verify the directory entry filename is valid")
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Siddharth Chandrasekaran <csiddharth@vmware.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/readdir.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/fs/readdir.c
    +++ b/fs/readdir.c
    @@ -91,9 +91,9 @@ EXPORT_SYMBOL(iterate_dir);
    */
    static int verify_dirent_name(const char *name, int len)
    {
    - if (WARN_ON_ONCE(!len))
    + if (!len)
    return -EIO;
    - if (WARN_ON_ONCE(memchr(name, '/', len)))
    + if (memchr(name, '/', len))
    return -EIO;
    return 0;
    }

    \
     
     \ /
      Last update: 2020-01-02 23:23    [W:3.555 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site