Messages in this thread |  | | From | Jolly Shah <> | Subject | RE: [PATCH 0/5] firmware: xilinx: Add xilinx specific sysfs interface | Date | Thu, 2 Jan 2020 21:01:58 +0000 |
| |
Hi Sudeep,
Thanks for the review.
> -----Original Message----- > From: Sudeep Holla <sudeep.holla@arm.com> > Sent: Wednesday, December 18, 2019 6:46 AM > To: Jolly Shah <JOLLYS@xilinx.com> > Cc: ard.biesheuvel@linaro.org; mingo@kernel.org; > gregkh@linuxfoundation.org; matt@codeblueprint.co.uk; > hkallweit1@gmail.com; keescook@chromium.org; > dmitry.torokhov@gmail.com; Michal Simek <michals@xilinx.com>; Rajan Vaja > <RAJANV@xilinx.com>; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org; Sudeep Holla <sudeep.holla@arm.com> > Subject: Re: [PATCH 0/5] firmware: xilinx: Add xilinx specific sysfs interface > > On Wed, Dec 04, 2019 at 03:29:14PM -0800, Jolly Shah wrote: > > This patch series adds xilinx specific sysfs interface for below > > purposes: > > - Register access > > - Set shutdown scope > > - Set boot health status bit > > This series defeats the whole abstraction EEMI provides. By providing > direct register accesses, you are allowing user-space to do whatever it > wants. I had NACKed this idea before. Has anything changed ? >
Firmware checks for allowed accesses only and rejects rest.
> If you need it for testing firmware, better put them in debugfs which is > off on production builds.
Sure. Will reanalyze use cases and move to debugfs only if that suffices.
Thanks, Jolly Shah
> > -- > Regards, > Sudeep
|  |