[lkml]   [2020]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCHv4 06/14] remoteproc/omap: Initialize and assign reserved memory node
From: Suman Anna <>

The reserved memory nodes are not assigned to platform devices by
default in the driver core to avoid the lookup for every platform
device and incur a penalty as the real users are expected to be
only a few devices.

OMAP remoteproc devices fall into the above category and the OMAP
remoteproc driver _requires_ specific CMA pools to be assigned
for each device at the moment to align on the location of the
vrings and vring buffers in the RTOS-side firmware images. So,
use the of_reserved_mem_device_init/release() API appropriately
to assign the corresponding reserved memory region to the OMAP
remoteproc device. Note that only one region per device is
allowed by the framework.

Signed-off-by: Suman Anna <>
Signed-off-by: Tero Kristo <>
Reviewed-by: Bjorn Andersson <>
drivers/remoteproc/omap_remoteproc.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c
index 9ca337f18ac2..8a6dd742a8b1 100644
--- a/drivers/remoteproc/omap_remoteproc.c
+++ b/drivers/remoteproc/omap_remoteproc.c
@@ -17,6 +17,7 @@
#include <linux/module.h>
#include <linux/err.h>
#include <linux/of_device.h>
+#include <linux/of_reserved_mem.h>
#include <linux/platform_device.h>
#include <linux/dma-mapping.h>
#include <linux/remoteproc.h>
@@ -480,14 +481,22 @@ static int omap_rproc_probe(struct platform_device *pdev)
if (ret)
goto free_rproc;

+ ret = of_reserved_mem_device_init(&pdev->dev);
+ if (ret) {
+ dev_err(&pdev->dev, "device does not have specific CMA pool\n");
+ goto free_rproc;
+ }
platform_set_drvdata(pdev, rproc);

ret = rproc_add(rproc);
if (ret)
- goto free_rproc;
+ goto release_mem;

return 0;

+ of_reserved_mem_device_release(&pdev->dev);
return ret;
@@ -499,6 +508,7 @@ static int omap_rproc_remove(struct platform_device *pdev)

+ of_reserved_mem_device_release(&pdev->dev);

return 0;
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

 \ /
  Last update: 2020-01-02 14:20    [W:0.244 / U:0.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site