[lkml]   [2020]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 33/37] platform/x86: intel_pmc_ipc: Move under MFD
On Thu, Jan 02, 2020 at 09:41:26AM +0000, Lee Jones wrote:
> On Mon, 23 Dec 2019, Mika Westerberg wrote:
> > This driver only creates a bunch of platform devices sharing resources
> > belonging to the PMC device. This is pretty much what MFD subsystem is
> > for so move the driver there, renaming it to intel_pmc_bxt.c which
> > should be more clear what it is. We convert the driver to call MFD APIs
> > in subsequent patches.
> Nope. Not happening.
> It's not appropriate to dump a 1000+ line source file into MFD without
> a thorough review. For starters, the 100's of lines of code which
> support the bespoke IPC APIs should remain within the 'platform'
> domain.
> It's okay to move the subordinate device registration into MFD, but it
> will need to be converted *whilst* transferring it, rather than the
> dump/edit method currently implemented.

OK, will do so in v2.

 \ /
  Last update: 2020-01-02 10:51    [W:0.070 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site