| Date | Mon, 20 Jan 2020 15:04:12 +1100 | From | Paul Mackerras <> | Subject | Re: [PATCH v2 12/45] KVM: PPC: Allocate vcpu struct in common PPC code |
| |
On Wed, Dec 18, 2019 at 01:54:57PM -0800, Sean Christopherson wrote: > Move allocation of all flavors of PPC vCPUs to common PPC code. All > variants either allocate 'struct kvm_vcpu' directly, or require that > the embedded 'struct kvm_vcpu' member be located at offset 0, i.e. > guarantee that the allocation can be directly interpreted as a 'struct > kvm_vcpu' object. > > Remove the message from the build-time assertion regarding placement of > the struct, as compatibility with the arch usercopy region is no longer > the sole dependent on 'struct kvm_vcpu' being at offset zero. > > Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
This fails to compile for Book E configs:
CC arch/powerpc/kvm/e500.o /home/paulus/kernel/kvm/arch/powerpc/kvm/e500.c: In function ‘kvmppc_core_vcpu_create_e500’: /home/paulus/kernel/kvm/arch/powerpc/kvm/e500.c:464:9: error: return makes integer from pointer without a cast [-Werror=int-conversion] return vcpu; ^ cc1: all warnings being treated as errors make[3]: *** [/home/paulus/kernel/kvm/scripts/Makefile.build:266: arch/powerpc/kvm/e500.o] Error 1
There is a "return vcpu" statement in kvmppc_core_vcpu_create_e500(), and another in kvmppc_core_vcpu_create_e500mc(), which both need to be changed to "return 0".
(By the way, I do appreciate you fixing the PPC code, even if there are some errors.)
Paul.
|