lkml.org 
[lkml]   [2020]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] tty: serial: amba-pl011: added RS485 support
From
Date
On 7. 1. 2020 at 8:27 Greg Kroah-Hartman wrote:

>> +config SERIAL_AMBA_PL011_SOFT_RS485
>> + bool "RS485 software direction switching for ARM AMBA PL011 serial"
>> + depends on SERIAL_AMBA_PL011=y
>
> Why "=y" here? Shouldn't this just read:
> depends on SERIAL_AMBA_PL011?
>
>> + select SERIAL_CORE
>
> Is this needed? SERIAL_AMBA_PL011 already selects this.

I am not sure. I found this few lines above:

> config SERIAL_AMBA_PL010_CONSOLE
> bool "Support for console on AMBA serial port"
> depends on SERIAL_AMBA_PL010=y
> select SERIAL_CORE_CONSOLE

and modified it for my purpose.


Thanks,

Ivan

\
 
 \ /
  Last update: 2020-01-17 01:32    [W:0.134 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site