Messages in this thread |  | | From | Shinichiro Kawasaki <> | Subject | Re: [f2fs-dev] [PATCH -next] f2fs: remove set but not used variable 'cs_block' | Date | Wed, 15 Jan 2020 02:33:28 +0000 |
| |
On Dec 26, 2019 / 17:24, Shin'ichiro Kawasaki wrote: > On Dec 26, 2019 / 14:05, Yuehaibing wrote: > > On 2019/12/26 11:44, Chao Yu wrote: > > > On 2019/12/24 20:43, YueHaibing wrote: > > >> fs/f2fs/segment.c: In function fix_curseg_write_pointer: > > >> fs/f2fs/segment.c:4485:35: warning: variable cs_block set but not used [-Wunused-but-set-variable] > > >> > > >> It is never used since commit 362d8a920384 ("f2fs: Check > > >> write pointer consistency of open zones") , so remove it. > > > > > > Thanks for the fix! > > > > > > Do you mind merging this patch to original patch? as it's still > > > pending in dev branch. > > > > It's ok for me. > > > > Thank you for this catch and the fix. Appreciated.
I have merged YueHaibing's change to the write pointer consistency fix patch and sent out as the v6 series. Thanks again for finding out the unused variable.
I was not sure if I should add Chao Yu's reviewed by tag to the patch from which the unused variable was removed. To be strict, I didn't add the tag. Just another quick review by Chao will be appreciated.
-- Best Regards, Shin'ichiro Kawasaki
|  |