[lkml]   [2020]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] ptp: free ptp device pin descriptors properly
From: Vladis Dronov <>
Date: Mon, 13 Jan 2020 14:00:09 +0100

> There is a bug in ptp_clock_unregister(), where ptp_cleanup_pin_groups()
> first frees ptp->pin_{,dev_}attr, but then posix_clock_unregister() needs
> them to destroy a related sysfs device.
> These functions can not be just swapped, as posix_clock_unregister() frees
> ptp which is needed in the ptp_cleanup_pin_groups(). Fix this by calling
> ptp_cleanup_pin_groups() in ptp_clock_release(), right before ptp is freed.
> This makes this patch fix an UAF bug in a patch which fixes an UAF bug.
> Reported-by: Antti Laakso <>
> Fixes: a33121e5487b ("ptp: fix the race between the release of ptp_clock and cdev")
> Link:
> Signed-off-by: Vladis Dronov <>

Applied, thank you.

 \ /
  Last update: 2020-01-14 20:01    [W:0.071 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site