Messages in this thread |  | | From | Rob Herring <> | Date | Mon, 13 Jan 2020 11:55:55 -0600 | Subject | Re: [PATCH v10 1/2] dt-bindings: phy: intel-emmc-phy: Add YAML schema for LGM eMMC PHY |
| |
On Mon, Dec 16, 2019 at 7:57 PM Ramuthevar,Vadivel MuruganX <vadivel.muruganx.ramuthevar@linux.intel.com> wrote: > > From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> > > Add a YAML schema to use the host controller driver with the > eMMC PHY on Intel's Lightning Mountain SoC. > > Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> > --- > .../bindings/phy/intel,lgm-emmc-phy.yaml | 56 ++++++++++++++++++++++ > 1 file changed, 56 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml > > diff --git a/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml b/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml > new file mode 100644 > index 000000000000..ff7959c21af0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.yaml > @@ -0,0 +1,56 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/intel,lgm-emmc-phy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Intel Lightning Mountain(LGM) eMMC PHY Device Tree Bindings > + > +maintainers: > + - Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com> > + > +description: |+ > + Bindings for eMMC PHY on Intel's Lightning Mountain SoC, syscon > + node is used to reference the base address of eMMC phy registers. > + > + The eMMC PHY node should be the child of a syscon node with the > + required property: > + > + - compatible: Should be one of the following: > + "intel,lgm-syscon", "syscon" > + - reg: > + maxItems: 1 > + > +properties: > + compatible: > + const: intel,lgm-emmc-phy > + > + "#phy-cells": > + const: 0 > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > +required: > + - "#phy-cells" > + - compatible > + - reg > + - clocks > + > +examples: > + - | > + sysconf: chiptop@e0200000 { > + compatible = "intel,lgm-syscon", "syscon"; > + reg = <0xe0200000 0x100>; > + > + emmc-phy: emmc-phy@a8 {
This fails in linux-next. Please run 'make dt_binding_check' and fix:
Error: Documentation/devicetree/bindings/phy/intel,lgm-emmc-phy.example.dts:21.19-20 syntax error FATAL ERROR: Unable to parse input tree
The problem is labels can't have '-'.
Rob
|  |