lkml.org 
[lkml]   [2020]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 1/2] platform/x86: Add support for Uncore frequency control
Hi Srinivas,
On Mon, Jan 13, 2020 at 11:59 AM Srinivas Pandruvada
<srinivas.pandruvada@linux.intel.com> wrote:
> +
> +/* Common function to set min/max ratios to be used by sysfs callbacks */
> +static int uncore_write_ratio(struct uncore_data *data, unsigned int input,
> + int set_max)
> +{
> + int ret;
> + u64 cap;
> +
> + mutex_lock(&uncore_lock);
> +
> + input /= UNCORE_FREQ_KHZ_MULTIPLIER;
> + if (!input || input > 0x7F) {
> + ret = -EINVAL;
> + goto finish_write;
> + }
> +
> + rdmsrl(MSR_UNCORE_RATIO_LIMIT, cap);
Should it be rdmsrl_on_cpu()?

Thanks,
Chenyu

\
 
 \ /
  Last update: 2020-01-13 08:02    [W:0.055 / U:1.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site