lkml.org 
[lkml]   [2020]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] cpu-topology: warn if NUMA configurations conflicts with lower layer
From
Date
On 13/01/2020 14:49, Dietmar Eggemann wrote:
> LGTM. This code detects the issue in cpu_coregroup_mask(), which is the
> the cpumask function of the sched domain MC level struct
> sched_domain_topology_level of ARM64's (and other archs)
> default_topology[].
> I wonder how x86 copes with such a config error?
> Maybe they do it inside their cpu_coregroup_mask()?
>
>
> We could move validate_topology_spans() into the existing
>
> for_each_cpu(i, cpu_map)
> for_each_sd_topology(tl)
>
> loop in build_sched_domains() saving some code?
>

[...]

Yeah that should work. Folks might want to gate it under SCHED_DEBUG, but
that's another discussion.

\
 
 \ /
  Last update: 2020-01-13 16:16    [W:0.108 / U:1.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site