[lkml]   [2020]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] rtc: i2c/spi: Avoid inclusion of REGMAP support when not needed
On Sun, 2020-01-12 at 18:13 +0100, Geert Uytterhoeven wrote:
> Merely enabling I2C and RTC selects REGMAP_I2C and REGMAP_SPI, even when
> no driver needs it. While the former can be moduler, the latter cannot,
> and thus becomes built-in.
> Fix this by moving the select statements for REGMAP_I2C and REGMAP_SPI
> from the RTC_I2C_AND_SPI helper to the individual drivers that depend on
> it.
> Note that the comment for RTC_I2C_AND_SPI refers to SND_SOC_I2C_AND_SPI
> for more information, but the latter does not select REGMAP_{I2C,SPI}
> itself, and defers that to the individual drivers, too.
> Fixes: 080481f54ef62121 ("rtc: merge ds3232 and ds3234")
> Signed-off-by: Geert Uytterhoeven <>
> ---
> Joe: When merging addresses, scripts/ replaces
> Alexandre's authoritative email address from MAINTAINERS by the
> obsolete address in the SoB-line of the commit referred to by the
> Fixes-line.

Hi Geert

What are you doing to get this changed output?

I get the same get_maintainer address output either way
with only with the 'blamed_fixes:' content added.

Your email with 'Fixes:' line:

$ ./scripts/ ~/geert_1.mbox
Alessandro Zummo <> (maintainer:REAL TIME CLOCK (RTC) SUBSYSTEM)
Alexandre Belloni <> (maintainer:REAL TIME CLOCK (RTC) SUBSYSTEM,blamed_fixes:1/1=100%)
Akinobu Mita <> (blamed_fixes:1/1=100%) (open list:REAL TIME CLOCK (RTC) SUBSYSTEM) (open list)

Your email without 'Fixes:' line:

$ ./scripts/ ~/geert_2.mbox
Alessandro Zummo <> (maintainer:REAL TIME CLOCK (RTC) SUBSYSTEM)
Alexandre Belloni <> (maintainer:REAL TIME CLOCK (RTC) SUBSYSTEM) (open list:REAL TIME CLOCK (RTC) SUBSYSTEM) (open list)

 \ /
  Last update: 2020-01-13 07:37    [W:3.076 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site