lkml.org 
[lkml]   [2020]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] drm/i915: convert to new logging macros based on struct intel_engine_cs.
Date
On Mon, 13 Jan 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Quoting Wambui Karuga (2020-01-13 11:10:25)
>> fn(...) {
>> ...
>> struct intel_engine_cs *E = ...;
>> +struct drm_i915_private *dev_priv = E->i915;
>
> No new dev_priv.

Wambui, we're gradually converting all dev_priv variable and parameter
names to i915.

> There should be no reason for drm_dbg here, as the rest of the debug is
> behind ENGINE_TRACE and so the vestigial debug should be moved over, or
> deleted as not being useful.
>
> The error messages look unhelpful.

I don't think you can expect any meaninful improvements on the debug
message contents from Wambui without detailed help at this point.

>
>> if ((batch_end - cmd) < length) {
>> - DRM_DEBUG("CMD: Command length exceeds batch length: 0x%08X length=%u batchlen=%td\n",
>> - *cmd,
>> - length,
>> - batch_end - cmd);
>> + drm_dbg(&dev_priv->drm,
>> + "CMD: Command length exceeds batch length: 0x%08X length=%u batchlen=%td\n",
>
> No. This is not driver debug. If anything this should be pr_debug, or
> some over user centric channel.

I'm sorry, I still don't understand your reasoning here.

BR,
Jani.

--
Jani Nikula, Intel Open Source Graphics Center

\
 
 \ /
  Last update: 2020-01-13 13:08    [W:0.092 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site