lkml.org 
[lkml]   [2020]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH v2] fbdev: potential information leak in do_fb_ioctl()
    The "fix" struct has a 2 byte hole after ->ywrapstep and the
    "fix = info->fix;" assignment doesn't necessarily clear it. It depends
    on the compiler. The solution is just to replace the assignment with an
    memcpy().

    Fixes: 1f5e31d7e55a ("fbmem: don't call copy_from/to_user() with mutex held")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    ---
    v2: Use memcpy()

    drivers/video/fbdev/core/fbmem.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c
    index d04554959ea7..bb8d8dbc0461 100644
    --- a/drivers/video/fbdev/core/fbmem.c
    +++ b/drivers/video/fbdev/core/fbmem.c
    @@ -1115,7 +1115,7 @@ static long do_fb_ioctl(struct fb_info *info, unsigned int cmd,
    break;
    case FBIOGET_FSCREENINFO:
    lock_fb_info(info);
    - fix = info->fix;
    + memcpy(&fix, &info->fix, sizeof(fix));
    if (info->flags & FBINFO_HIDE_SMEM_START)
    fix.smem_start = 0;
    unlock_fb_info(info);
    --
    2.11.0
    \
     
     \ /
      Last update: 2020-01-13 12:11    [W:2.881 / U:27.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site