Messages in this thread |  | | Date | Mon, 13 Jan 2020 11:19:47 +0100 | From | Michael Walle <> | Subject | Re: [PATCH 2/2] mtd: spi-nor: fix locking argument in spi_nor_is_locked() |
| |
Am 2020-01-13 11:10, schrieb Tudor.Ambarus@microchip.com: > Hi, Michael, > > On Wednesday, January 8, 2020 12:23:17 AM EET Michael Walle wrote: >> diff --git a/include/linux/mtd/spi-nor.h b/include/linux/mtd/spi-nor.h >> index b661fd948a25..a8fcb1d70510 100644 >> --- a/include/linux/mtd/spi-nor.h >> +++ b/include/linux/mtd/spi-nor.h >> @@ -235,6 +235,7 @@ enum spi_nor_ops { >> SPI_NOR_OPS_ERASE, >> SPI_NOR_OPS_LOCK, >> SPI_NOR_OPS_UNLOCK, >> + SPI_NOR_OPS_IS_LOCKED, >> }; > > There is no NOR controller that uses this enum, can we get rid of it?
you mean the second argument of the spi_nor_lock_and_prep() and spi_nor_unlock_and_unprep()? sure. But it removes information from the prepare() callback. like in "prepare what?". From what I see its only used for locking. Maybe then rename it to prepare_lock and prepare_unlock.
-michael
|  |