| From | Thomas Gleixner <> | Subject | Re: [PATCHv8 20/34] lib/vdso: Prepare for time namespace support | Date | Sun, 12 Jan 2020 11:32:12 +0100 |
| |
Dmitry Safonov <dima@arista.com> writes: > From: Thomas Gleixner <tglx@linutronix.de> > +#ifdef CONFIG_TIME_NS > +static int do_hres_timens(const struct vdso_data *vdns, clockid_t clk, > + struct __kernel_timespec *ts) > +{ > + const struct vdso_data *vd = __arch_get_timens_vdso_data(); > + const struct vdso_timestamp *vdso_ts; > + const struct timens_offset *offs = &vdns->offset[clk]; > + u64 cycles, last, ns; > + u32 seq, msk; > + s64 sec; > + > + msk = 1U << clk; > + if (msk & VDSO_HRES) > + vd = &vd[CS_HRES_COARSE]; > + else if (msk & VDSO_RAW) > + vd = &vd[CS_RAW]; > + else > + return -1;
This part is redundant. The initial call site already made sure that this is only called for clocks matching VDSO_HRES or VDSO_RAW. I just drop it.
Thanks,
tglx
|