[lkml]   [2020]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [Patch v7 4/7] sched/fair: Enable periodic update of average thermal pressure
Hi Thara,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on next-20200110]
[also build test ERROR on v5.5-rc5]
[cannot apply to tip/sched/core tip/perf/core arm/for-next arm64/for-next/core driver-core/driver-core-testing linus/master v5.5-rc5 v5.5-rc4 v5.5-rc3]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see]

base: 6c09d7dbb7d366122d0218bc7487e0a1e6cca6ed
config: mips-fuloong2e_defconfig (attached as .config)
compiler: mips64el-linux-gcc (GCC) 5.5.0
wget -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=5.5.0 make.cross ARCH=mips

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <>

All errors (new ones prefixed by >>):

kernel/sched/fair.c: In function 'task_tick_fair':
>> kernel/sched/fair.c:10308:2: error: implicit declaration of function 'update_thermal_load_avg' [-Werror=implicit-function-declaration]
update_thermal_load_avg(rq_clock_task(rq), rq, thermal_pressure);
cc1: some warnings being treated as errors

vim +/update_thermal_load_avg +10308 kernel/sched/fair.c

10284 /*
10285 * scheduler tick hitting a task of our scheduling class.
10286 *
10287 * NOTE: This function can be called remotely by the tick offload that
10288 * goes along full dynticks. Therefore no local assumption can be made
10289 * and everything must be accessed through the @rq and @curr passed in
10290 * parameters.
10291 */
10292 static void task_tick_fair(struct rq *rq, struct task_struct *curr, int queued)
10293 {
10294 struct cfs_rq *cfs_rq;
10295 struct sched_entity *se = &curr->se;
10296 unsigned long thermal_pressure = arch_cpu_thermal_pressure(cpu_of(rq));
10298 for_each_sched_entity(se) {
10299 cfs_rq = cfs_rq_of(se);
10300 entity_tick(cfs_rq, se, queued);
10301 }
10303 if (static_branch_unlikely(&sched_numa_balancing))
10304 task_tick_numa(rq, curr);
10306 update_misfit_status(curr, rq);
10307 update_overutilized_status(task_rq(curr));
10308 update_thermal_load_avg(rq_clock_task(rq), rq, thermal_pressure);
10309 }

0-DAY kernel test infrastructure Open Source Technology Center Intel Corporation
[unhandled content-type:application/gzip]
 \ /
  Last update: 2020-01-12 06:45    [W:0.077 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site