Messages in this thread |  | | From | Andy Shevchenko <> | Date | Fri, 10 Jan 2020 22:52:49 +0200 | Subject | Re: [PATCH] power: supply: olpc_battery: fix the power supply name |
| |
On Fri, Jan 10, 2020 at 10:00 PM Lubomir Rintel <lkundrak@v3.sk> wrote: > On Thu, 2020-01-09 at 17:09 +0200, Andy Shevchenko wrote: > > On Sat, Dec 21, 2019 at 9:18 AM Lubomir Rintel <lkundrak@v3.sk> wrote: > > > The framework is unhappy about them, because it uses the names in sysfs > > > attributes: > > > > > > power_supply olpc-ac: hwmon: 'olpc-ac' is not a valid name attribute, please fix > > > power_supply olpc-battery: hwmon: 'olpc-battery' is not a valid name attribute, please fix > > > > I'm wondering if it's an ABI change and how user space is supposed to > > cope with it. > > It changes the sysfs path. It is rather unlikely that udisks or > anything else userspace cares. > > If it does, then I guess the warning that suggests that it's a bug that > should be fixed should be removed instead.
That said, I'm fine with this as long as power_supply subsystem maintainer does.
-- With Best Regards, Andy Shevchenko
|  |