lkml.org 
[lkml]   [2020]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[tip: x86/mm] x86/mm/pat: Create fixed width output in /sys/kernel/debug/x86/pat_memtype_list, similar to the E820 debug printouts
The following commit has been merged into the x86/mm branch of tip:

Commit-ID: ef35b0fcee23d7636daa4bed62bceeaba4eed918
Gitweb: https://git.kernel.org/tip/ef35b0fcee23d7636daa4bed62bceeaba4eed918
Author: Ingo Molnar <mingo@kernel.org>
AuthorDate: Tue, 19 Nov 2019 09:38:26 +01:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Tue, 10 Dec 2019 10:12:55 +01:00

x86/mm/pat: Create fixed width output in /sys/kernel/debug/x86/pat_memtype_list, similar to the E820 debug printouts

Before:

write-back @ 0xbdfa9000-0xbdfaa000
write-back @ 0xbdfaa000-0xbdfab000
write-back @ 0xbdfab000-0xbdfac000
uncached-minus @ 0xc0000000-0xd0000000
uncached-minus @ 0xd0900000-0xd0920000
uncached-minus @ 0xd0920000-0xd0940000
uncached-minus @ 0xd0940000-0xd0960000
uncached-minus @ 0xd0960000-0xd0980000
uncached-minus @ 0xd0980000-0xd0981000
uncached-minus @ 0xd0990000-0xd0991000
uncached-minus @ 0xd09a0000-0xd09a1000
uncached-minus @ 0xd09b0000-0xd09b1000
uncached-minus @ 0xd0d00000-0xd0d01000
uncached-minus @ 0xd0d10000-0xd0d11000
uncached-minus @ 0xd0d20000-0xd0d21000
uncached-minus @ 0xd0d40000-0xd0d41000
uncached-minus @ 0xfed00000-0xfed01000
uncached-minus @ 0xfed1f000-0xfed20000
uncached-minus @ 0xfed40000-0xfed41000

After:

PAT: [mem 0x00000000bdf8e000-0x00000000bdfa8000] write-back
PAT: [mem 0x00000000bdfa9000-0x00000000bdfaa000] write-back
PAT: [mem 0x00000000bdfaa000-0x00000000bdfab000] write-back
PAT: [mem 0x00000000bdfab000-0x00000000bdfac000] write-back
PAT: [mem 0x00000000c0000000-0x00000000d0000000] uncached-minus
PAT: [mem 0x00000000d0900000-0x00000000d0920000] uncached-minus
PAT: [mem 0x00000000d0920000-0x00000000d0940000] uncached-minus
PAT: [mem 0x00000000d0940000-0x00000000d0960000] uncached-minus
PAT: [mem 0x00000000d0960000-0x00000000d0980000] uncached-minus
PAT: [mem 0x00000000d0980000-0x00000000d0981000] uncached-minus
PAT: [mem 0x00000000d0990000-0x00000000d0991000] uncached-minus
PAT: [mem 0x00000000d09a0000-0x00000000d09a1000] uncached-minus
PAT: [mem 0x00000000d09b0000-0x00000000d09b1000] uncached-minus
PAT: [mem 0x00000000fed1f000-0x00000000fed20000] uncached-minus
PAT: [mem 0x00000000fed40000-0x00000000fed41000] uncached-minus

The advantage is that it's easier to parse at a glance - and the tree is ordered
by start address, which is now reflected in putting the start address in the first
column.

This is also now similar to how we print e820 entries:

BIOS-e820: [mem 0x00000000bafda000-0x00000000bb3d3fff] usable
BIOS-e820: [mem 0x00000000bb3d4000-0x00000000bdd2efff] reserved
BIOS-e820: [mem 0x00000000bdd2f000-0x00000000bddccfff] ACPI NVS
BIOS-e820: [mem 0x00000000bddcd000-0x00000000bdea0fff] ACPI data
BIOS-e820: [mem 0x00000000bdea1000-0x00000000bdf2efff] ACPI NVS

Since this is a debugfs file not used by tools there's no known ABI dependencies.

Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/mm/pat.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/mm/pat.c b/arch/x86/mm/pat.c
index e26b81c..ea7da7e 100644
--- a/arch/x86/mm/pat.c
+++ b/arch/x86/mm/pat.c
@@ -1179,10 +1179,10 @@ static int memtype_seq_show(struct seq_file *seq, void *v)
{
struct memtype *print_entry = (struct memtype *)v;

- seq_printf(seq, "%s @ 0x%Lx-0x%Lx\n",
- cattr_name(print_entry->type),
+ seq_printf(seq, "PAT: [mem 0x%016Lx-0x%016Lx] %s\n",
print_entry->start,
- print_entry->end);
+ print_entry->end,
+ cattr_name(print_entry->type));

kfree(print_entry);

\
 
 \ /
  Last update: 2020-01-10 19:00    [W:0.027 / U:27.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site