lkml.org 
[lkml]   [2020]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 1/3] clocksource: davinci: only enable clockevents once tim34 is initialized
From
Date
On 10/01/2020 18:16, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> The DM365 platform has a strange quirk (only present when using ancient
> u-boot - mainline u-boot v2013.01 and later works fine) where if we
> enable the second half of the timer in periodic mode before we do its
> initialization - the time won't start flowing and we can't boot.
>
> When using more recent u-boot, we can enable the timer, then reinitialize
> it and all works fine.
>
> To work around this issue only enable clockevents once tim34 is
> initialized i.e. move clockevents_config_and_register() below tim34
> initialization.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

Shall I take it through my tree?

> ---
> drivers/clocksource/timer-davinci.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clocksource/timer-davinci.c b/drivers/clocksource/timer-davinci.c
> index 62745c962049..e421946a91c5 100644
> --- a/drivers/clocksource/timer-davinci.c
> +++ b/drivers/clocksource/timer-davinci.c
> @@ -302,10 +302,6 @@ int __init davinci_timer_register(struct clk *clk,
> return rv;
> }
>
> - clockevents_config_and_register(&clockevent->dev, tick_rate,
> - DAVINCI_TIMER_MIN_DELTA,
> - DAVINCI_TIMER_MAX_DELTA);
> -
> davinci_clocksource.dev.rating = 300;
> davinci_clocksource.dev.read = davinci_clocksource_read;
> davinci_clocksource.dev.mask =
> @@ -323,6 +319,10 @@ int __init davinci_timer_register(struct clk *clk,
> davinci_clocksource_init_tim34(base);
> }
>
> + clockevents_config_and_register(&clockevent->dev, tick_rate,
> + DAVINCI_TIMER_MIN_DELTA,
> + DAVINCI_TIMER_MAX_DELTA);
> +
> rv = clocksource_register_hz(&davinci_clocksource.dev, tick_rate);
> if (rv) {
> pr_err("Unable to register clocksource");
>


--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

\
 
 \ /
  Last update: 2020-01-10 18:57    [W:0.052 / U:5.840 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site