[lkml]   [2020]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[tip: perf/core] perf report/top: Make 'e' visible in the help and make it toggle showing callchains
The following commit has been merged into the perf/core branch of tip:

Commit-ID: e6d6abfc447a65e949c1e883e66e1450903d2fbd
Author: Arnaldo Carvalho de Melo <>
AuthorDate: Tue, 17 Dec 2019 10:39:04 -03:00
Committer: Arnaldo Carvalho de Melo <>
CommitterDate: Mon, 06 Jan 2020 11:46:10 -03:00

perf report/top: Make 'e' visible in the help and make it toggle showing callchains

The 'e' and 'c' hotkeys were present for a long time, but not documented
in the help window, change 'e' to be a toggle so that it gets consistent
with other toggles like '+' and document it in the help window.

Keep 'c' as is for people used to it but don't document, as it is easier
to just use 'e' to show/hide all the callchains for a top level
histogram entry.

Reviewed-by: Jiri Olsa <>
Cc: Adrian Hunter <>
Cc: Andi Kleen <>
Cc: Jin Yao <>
Cc: Kan Liang <>
Cc: Linus Torvalds <>
Cc: Namhyung Kim <>
Signed-off-by: Arnaldo Carvalho de Melo <>
tools/perf/ui/browsers/hists.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
index 3bec8de..f36dee4 100644
--- a/tools/perf/ui/browsers/hists.c
+++ b/tools/perf/ui/browsers/hists.c
@@ -407,6 +407,11 @@ static bool hist_browser__selection_has_children(struct hist_browser *browser)
return container_of(ms, struct callchain_list, ms)->has_children;

+static bool hist_browser__he_selection_unfolded(struct hist_browser *browser)
+ return browser->he_selection ? browser->he_selection->unfolded : false;
static bool hist_browser__selection_unfolded(struct hist_browser *browser)
struct hist_entry *he = browser->he_selection;
@@ -727,7 +732,7 @@ static int hist_browser__handle_hotkey(struct hist_browser *browser, bool warn_l
case 'e':
/* Expand the selected entry. */
- hist_browser__set_folding_selected(browser, true);
+ hist_browser__set_folding_selected(browser, !hist_browser__he_selection_unfolded(browser));
case 'H':
browser->show_headers = !browser->show_headers;
@@ -2942,6 +2947,7 @@ static int perf_evsel__hists_browse(struct evsel *evsel, int nr_events,
"a Annotate current symbol\n" \
"C Collapse all callchains\n" \
"d Zoom into current DSO\n" \
+ "e Expand/Collapse main entry callchains\n" \
"E Expand all callchains\n" \
"F Toggle percentage of filtered entries\n" \
"H Display column headers\n" \
 \ /
  Last update: 2020-01-10 18:55    [W:0.028 / U:0.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site