lkml.org 
[lkml]   [2020]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3] coccinelle: semantic patch to check for inappropriate do_div() calls
From
Date
> +@initialize:python@

> +def filter_out_safe_constants(str):

> +def construct_warnings(str, suggested_fun):

* I suggest once more to adjust the dependency specifications for the usage
of these functions by SmPL rules.

* Can the local variable “msg” be omitted?


> +coccilib.org.print_todo(p[0], construct_warnings("div64_ul"))

I suggest again to move the prefix “div64_” into the string literal
of the function implementation.


The SmPL code for two disjunctions could become shorter.

Regards,
Markus

\
 
 \ /
  Last update: 2020-01-10 17:36    [W:0.082 / U:1.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site