lkml.org 
[lkml]   [2020]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [alsa-devel] [PATCH 4/6] soundwire: stream: do not update parameters during DISABLED-PREPARED transition
From
Date

>> + /*
>> + * when the stream is DISABLED, this means sdw_prepare_stream()
>> + * is called as a result of an underflow or a resume operation.
>> + * In this case, the bus parameters shall not be recomputed, but
>> + * still need to be re-applied
>> + */
>> + if (stream->state == SDW_STREAM_DISABLED)
>> + update_params = false;
>
> Should this not be handled by the caller..? I do not like to deduce this
> here as the info is already available in dai driver, so go ahead and
> propagate it and get it from caller when it is required..

No, this update_params boolean is used later on to modify the bandwidth
computation. These values are not accessible to the caller (and should
absolutely be kept private/opaque).

\
 
 \ /
  Last update: 2020-01-10 17:13    [W:0.055 / U:3.816 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site