lkml.org 
[lkml]   [2020]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] arm64/mm/dump: fix a compilation error
On Fri, Jan 10, 2020 at 03:34:48PM +0000, Steven Price wrote:
> On Fri, Jan 10, 2020 at 02:51:12PM +0000, Qian Cai wrote:
> > The linux-next commit "x86: mm: avoid allocating struct mm_struct on the
> > stack" [1] introduced a compilation error with "arm64: mm: convert
> > mm/dump.c to use walk_page_range()" [2]. Fixed it by using the new API.
> >
> > arch/arm64/mm/dump.c:326:38: error: too few arguments to function call,
> > expected 3, have 2
> > ptdump_walk_pgd(&st.ptdump, info->mm);
> > ~~~~~~~~~~~~~~~ ^
> > ./include/linux/ptdump.h:20:1: note: 'ptdump_walk_pgd' declared here
> > void ptdump_walk_pgd(struct ptdump_state *st, struct mm_struct *mm,
> > pgd_t *pgd);
> > ^
> > arch/arm64/mm/dump.c:364:38: error: too few arguments to function call,
> > expected 3, have 2
> > ptdump_walk_pgd(&st.ptdump, &init_mm);
> > ~~~~~~~~~~~~~~~ ^
> > ./include/linux/ptdump.h:20:1: note: 'ptdump_walk_pgd' declared here
> > void ptdump_walk_pgd(struct ptdump_state *st, struct mm_struct *mm,
> > pgd_t *pgd);
> > ^
> > 2 errors generated.
> >
> > [1] http://lkml.kernel.org/r/20200108145710.34314-1-steven.price@arm.com
>
> Actually this was in the patch I originally posted - somehow it got
> lost when Andrew picked it up.
>
> > [2] http://lkml.kernel.org/r/20191218162402.45610-22-steven.price@arm.com
> >
> > Signed-off-by: Qian Cai <cai@lca.pw>
>
> Since this matches what I originally wrote... ;)
>
> Reviewed-by: Steven Price <steven.price@arm.com>

Acked-by: Will Deacon <will@kernel.org>

I'm assuming Andrew will queue this alongside the others.

Thanks,

Will

\
 
 \ /
  Last update: 2020-01-10 17:08    [W:0.027 / U:2.984 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site