lkml.org 
[lkml]   [2020]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mm/page_alloc: Skip non present sections on zone initialization
From
Date
On 10.01.20 15:54, Kirill A. Shutemov wrote:
> On Fri, Jan 10, 2020 at 03:48:39PM +0100, David Hildenbrand wrote:
>>>> + if (!present_section_nr(section_nr))
>>>> + return section_nr_to_pfn(next_present_section_nr(section_nr));
>>>
>>> This won't compile. next_present_section_nr() is static to mm/sparse.c.
>>
>> We should then move that to the header IMHO.
>
> It looks like too much for a trivial cleanup.
>

Cleanup? This is a performance improvement ("fix the issue."). We should
avoid duplicating code where it can be avoided.

--
Thanks,

David / dhildenb

\
 
 \ /
  Last update: 2020-01-10 15:57    [W:0.076 / U:9.940 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site