lkml.org 
[lkml]   [2020]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/2] dt-bindings: arm64: dts: mediatek: Add mt8173 elm and hana
From
Date
Hi Hsin-Yi,

Just a nit that is most a decision of the maintainer ...

On 10/1/20 8:37, Hsin-Yi Wang wrote:
> Elm is Acer Chromebook R13. Hana is Lenovo Chromebook. Both uses mt8173
> SoC.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>

Tested with patch 2 applied and saw that there is no errors with dtbs_check.

Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

> ---
> Changes in v2:
> - fix dtbs_check errors, use const instead of enum
> ---
> .../devicetree/bindings/arm/mediatek.yaml | 27 +++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index 4043c5046441..5272899b08fa 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -84,6 +84,33 @@ properties:
> - enum:
> - mediatek,mt8135-evbp1
> - const: mediatek,mt8135
> + - description: Google Elm (Acer Chromebook R13)
> + items:
> + - const: google,elm-rev8
> + - const: google,elm-rev7
> + - const: google,elm-rev6
> + - const: google,elm-rev5
> + - const: google,elm-rev4
> + - const: google,elm-rev3
> + - const: google,elm-rev2
> + - const: google,elm-rev1
> + - const: google,elm
> + - const: mediatek,mt8173
> + - description: Google Hana (Lenovo Chromebook and more)

nit: and more? How many? I'd expect the commercial model names here

Lenovo Chromebook C330?

Thanks,
Enric

> + items:
> + - const: google,hana-rev6
> + - const: google,hana-rev5
> + - const: google,hana-rev4
> + - const: google,hana-rev3
> + - const: google,hana-rev2
> + - const: google,hana-rev1
> + - const: google,hana-rev0
> + - const: google,hana
> + - const: mediatek,mt8173
> + - description: Google Hana rev7 (Poin2 Chromebook 11C)
> + items:
> + - const: google,hana-rev7
> + - const: mediatek,mt8173
> - items:
> - enum:
> - mediatek,mt8173-evb
>

\
 
 \ /
  Last update: 2020-01-10 12:39    [W:0.094 / U:6.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site