lkml.org 
[lkml]   [2020]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/nmi: remove the irqwork from long duration nmi handler
On Fri, Jan 10, 2020 at 08:58:37PM +0100, Borislav Petkov wrote:
> On Fri, Jan 10, 2020 at 05:34:50PM +0000, Changbin Du wrote:
> > Just to move all the check code together and be a standalone function.
> > yes, this somewhat does code refining after the irqwork is removed but
> > I think it is normal.
>
> But it makes review harder because your patch is removing irq_work,
> *nothing* in the commit message is talking about *why* you're doing
> that additional change. I'd imagine at the end of the commit message
> something like:
>
> "While at it, repurpose the IRQ work callback into a function which
> concentrates the NMI duration checking."
>
> This lets a reader know know why that additional change is done instead
> of going back'n'forth and having to ask you why you're doing this.
>
> Ok?
>
sure, and thanks for your suggestion. I will send v2 later.

> --
> Regards/Gruss,
> Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette

--
Cheers,
Changbin Du

\
 
 \ /
  Last update: 2020-01-11 01:18    [W:0.039 / U:2.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site