lkml.org 
[lkml]   [2019]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] x86/umip: Add emulation for 64-bit processes
From
Date

> On Sep 7, 2019, at 2:26 PM, Ricardo Neri <ricardo.neri-calderon@linux.intel.com> wrote:
>
> On Thu, Sep 05, 2019 at 04:22:21PM -0700, Brendan Shanks wrote:
>>
>> if (umip_inst == UMIP_INST_SGDT || umip_inst == UMIP_INST_SIDT) {
>> + u64 dummy_base_addr;
>> + u16 dummy_limit = 0;
>> +
>> /* SGDT and SIDT do not use registers operands. */
>> if (X86_MODRM_MOD(insn->modrm.value) == 3)
>> return -EINVAL;
>> @@ -228,13 +228,24 @@ static int emulate_umip_insn(struct insn *insn, int umip_inst,
>> else
>> dummy_base_addr = UMIP_DUMMY_IDT_BASE;
>>
>> - *data_size = UMIP_GDT_IDT_LIMIT_SIZE + UMIP_GDT_IDT_BASE_SIZE;
>
> Maybe a blank line here?

Adding a blank line in place of the removed line? I’m not sure I see the need for it, there’s already a blank line above, and it's followed by the block comment.

Brendan
\
 
 \ /
  Last update: 2019-09-10 00:35    [W:0.075 / U:4.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site