lkml.org 
[lkml]   [2019]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/5] mm, slab: Make kmalloc_info[] contain all types of names
From
Date
On 9/9/19 8:30 PM, Rasmus Villemoes wrote:
> On 09/09/2019 18.53, Pengfei Li wrote:
>> On Mon, Sep 9, 2019 at 10:59 PM Vlastimil Babka <vbabka@suse.cz> wrote:
>
>>>> /*
>>>> * kmalloc_info[] is to make slub_debug=,kmalloc-xx option work at boot time.
>>>> * kmalloc_index() supports up to 2^26=64MB, so the final entry of the table is
>>>> * kmalloc-67108864.
>>>> */
>>>> const struct kmalloc_info_struct kmalloc_info[] __initconst = {
>>>
>>> BTW should it really be an __initconst, when references to the names
>>> keep on living in kmem_cache structs? Isn't this for data that's
>>> discarded after init?
>>
>> You are right, I will remove __initconst in v2.
>
> No, __initconst is correct, and should be kept. The string literals
> which the .name pointers point to live in .rodata, and we're copying the
> values of these .name pointers. Nothing refers to something inside
> kmalloc_info[] after init. (It would be a whole different matter if
> struct kmalloc_info_struct consisted of { char name[NN]; unsigned int
> size; }).

*slaps forehead* ah, of course, string literals themselves are not
affected by the __initconst, thanks! Sorry for the wrong suggestion Pengfei.

> Rasmus
>

\
 
 \ /
  Last update: 2019-09-09 21:49    [W:0.068 / U:5.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site