lkml.org 
[lkml]   [2019]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Patch 09/13] media: am437x-vpfe: fix function trace debug log
Joe Perches <joe@perches.com> wrote on Mon [2019-Sep-09 09:54:56 -0700]:
> On Mon, 2019-09-09 at 11:27 -0500, Benoit Parrot wrote:
> > checkpatch.pl nows reports several:
> > WARNING: Prefer using '"%s...", __func__' to using '<function name>',
> > this function's name, in a string
> >
> > So fix these for the whole driver.
>
> Most of these seem to be function tracing comments
> that should probably be removed instead.
>
> The generic kernel facility ftrace works well.

Yeah you are probably right, I should just remove them.
My own laziness prevented me earlier... it's always easier to just enable
debug dynamically in the driver then trying to remember how to use ftrace :)
I obviously don't use often enough.

Benoit

>
> > diff --git a/drivers/media/platform/am437x/am437x-vpfe.c b/drivers/media/platform/am437x/am437x-vpfe.c
> []
> > @@ -466,7 +466,7 @@ static void vpfe_ccdc_config_ycbcr(struct vpfe_ccdc *ccdc)
> > struct ccdc_params_ycbcr *params = &ccdc->ccdc_cfg.ycbcr;
> > u32 syn_mode;
> >
> > - vpfe_dbg(3, vpfe, "vpfe_ccdc_config_ycbcr:\n");
> > + vpfe_dbg(3, vpfe, "%s:\n", __func__);
>
> Remove this instead
>
> > /*
> > * first restore the CCDC registers to default values
> > * This is important since we assume default values to be set in
> > @@ -598,7 +598,7 @@ static void vpfe_ccdc_config_raw(struct vpfe_ccdc *ccdc)
> > unsigned int syn_mode;
> > unsigned int val;
> >
> > - vpfe_dbg(3, vpfe, "vpfe_ccdc_config_raw:\n");
> > + vpfe_dbg(3, vpfe, "%s:\n", __func__);
>
> here too, etc...
>
>

\
 
 \ /
  Last update: 2019-09-09 19:13    [W:0.090 / U:0.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site