lkml.org 
[lkml]   [2019]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/12] crypto: caam - make sure clocks are enabled first
On Mon, Sep 09, 2019 at 05:21:55PM +1000, Herbert Xu wrote:
> On Fri, Sep 06, 2019 at 11:18:19AM +0000, Horia Geanta wrote:
> > On 9/4/2019 5:35 AM, Andrey Smirnov wrote:
> > > In order to access IP block's registers we need to enable appropriate
> > > clocks first, otherwise we are risking hanging the CPU.
> > >
> > > The problem becomes very apparent when trying to use CAAM driver built
> > > as a kernel module. In that case caam_probe() gets called after
> > > clk_disable_unused() which means all of the necessary clocks are
> > > guaranteed to be disabled.
> > >
> > > Coincidentally, this change also fixes iomap leak introduced by early
> > > return (instead of "goto iounmap_ctrl") in commit
> > > 41fc54afae70 ("crypto: caam - simplfy clock initialization")
> > >
> > > Tested on ZII i.MX6Q+ RDU2
> > >
> > > Fixes: 176435ad2ac7 ("crypto: caam - defer probing until QMan is available")
> > > Fixes: 41fc54afae70 ("crypto: caam - simplfy clock initialization")
> > > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> > > Cc: Chris Healy <cphealy@gmail.com>
> > > Cc: Lucas Stach <l.stach@pengutronix.de>
> > > Cc: Horia Geantă <horia.geanta@nxp.com>
> > > Cc: Herbert Xu <herbert@gondor.apana.org.au>
> > > Cc: Iuliana Prodan <iuliana.prodan@nxp.com>
> > > Cc: linux-crypto@vger.kernel.org
> > > Cc: linux-kernel@vger.kernel.org
> > Tested-by: Horia Geantă <horia.geanta@nxp.com>
> >
> > Considering this is a boot hang, in case this does not make into v5.4
> > I would appreciate appending:
> > Cc: <stable@vger.kernel.org>
>
> This patch does not apply against cryptodev or crypto.

Nevermind, I was trying to apply patch 4 on top of patch 1 which
is why it didn't work.

Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

\
 
 \ /
  Last update: 2019-09-09 09:23    [W:0.073 / U:6.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site