lkml.org 
[lkml]   [2019]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 00/12] CAAM bugfixes, small improvements
Date
On 9/9/2019 10:53 AM, Herbert Xu wrote:
> On Tue, Sep 03, 2019 at 07:35:03PM -0700, Andrey Smirnov wrote:
>> Everyone:
>>
>> This series bugfixes and small improvement I made while doing more
>> testing of CAAM code:
>>
>> - "crypto: caam - make sure clocks are enabled first"
>>
>> fixes a recent regression (and, conincidentally a leak cause by one
>> of my i.MX8MQ patches)
>>
>> - "crypto: caam - use devres to unmap JR's registers"
>> "crypto: caam - check irq_of_parse_and_map for errors"
>>
>> are small improvements
>>
>> - "crypto: caam - dispose of IRQ mapping only after IRQ is freed"
>>
>> fixes a bug introduced by my i.MX8MQ series
>>
>> - "crypto: caam - use devres to unmap memory"
>> "crypto: caam - use devres to remove debugfs"
>> "crypto: caam - use devres to de-initialize the RNG"
>> "crypto: caam - use devres to de-initialize QI"
>> "crypto: caam - user devres to populate platform devices"
>> "crypto: caam - populate platform devices last"
>>
>> are devres conversions/small improvments
>>
>> - "crypto: caam - convert caamrng to platform device"
>> "crypto: caam - change JR device ownership scheme"
>>
>> are more of an RFC than proper fixes. I don't have a very high
>> confidence in those fixes, but I think they are a good conversation
>> stater about the best approach to fix those issues
>>
>> Thanks,
>> Andrey Smirnov
>>
>> Andrey Smirnov (12):
>> crypto: caam - make sure clocks are enabled first
>> crypto: caam - use devres to unmap JR's registers
>> crypto: caam - check irq_of_parse_and_map for errors
>> crypto: caam - dispose of IRQ mapping only after IRQ is freed
>> crypto: caam - use devres to unmap memory
>> crypto: caam - use devres to remove debugfs
>> crypto: caam - use devres to de-initialize the RNG
>> crypto: caam - use devres to de-initialize QI
>> crypto: caam - user devres to populate platform devices
>> crypto: caam - populate platform devices last
>> crypto: caam - convert caamrng to platform device
>> crypto: caam - change JR device ownership scheme
>>
>> drivers/crypto/caam/caamrng.c | 102 +++++-------
>> drivers/crypto/caam/ctrl.c | 294 ++++++++++++++++++----------------
>> drivers/crypto/caam/intern.h | 4 -
>> drivers/crypto/caam/jr.c | 90 ++++++++---
>> drivers/crypto/caam/qi.c | 8 +-
>> drivers/crypto/caam/qi.h | 1 -
>> 6 files changed, 267 insertions(+), 232 deletions(-)
>
> All applied. Thanks.
>
Why all?
I've ack-ed only 1 and 4.

Besides this, patches 11 and/or 12 break the functionality,
i.e. driver gets stuck during crypto self-tests.

Horia

\
 
 \ /
  Last update: 2019-09-09 14:09    [W:0.194 / U:13.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site