lkml.org 
[lkml]   [2019]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] soc: amazon: al-pos: Introduce Amazon's Annapurna Labs POS driver
Hi Talel,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[cannot apply to v5.3-rc8 next-20190904]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Talel-Shenhar/Amazon-s-Annapurna-Labs-POS-Driver/20190909-180243
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=m68k

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

drivers/soc/amazon/al_pos.c: In function 'al_pos_irq_handler':
>> drivers/soc/amazon/al_pos.c:56:57: warning: left shift count >= width of type [-Wshift-count-overflow]
addr |= (FIELD_GET(AL_POS_ERROR_LOG_1_ADDR_HIGH, log1) << 32);
^~

vim +56 drivers/soc/amazon/al_pos.c

37
38 static irqreturn_t al_pos_irq_handler(int irq, void *info)
39 {
40 struct platform_device *pdev = info;
41 struct al_pos *pos = platform_get_drvdata(pdev);
42 u32 log1;
43 u32 log0;
44 u64 addr;
45 u16 request_id;
46 u8 bresp;
47
48 log1 = readl_relaxed(pos->mmio_base + AL_POS_ERROR_LOG_1);
49 if (!FIELD_GET(AL_POS_ERROR_LOG_1_VALID, log1))
50 return IRQ_NONE;
51
52 log0 = readl_relaxed(pos->mmio_base + AL_POS_ERROR_LOG_0);
53 writel_relaxed(0, pos->mmio_base + AL_POS_ERROR_LOG_1);
54
55 addr = FIELD_GET(AL_POS_ERROR_LOG_0_ADDR_LOW, log0);
> 56 addr |= (FIELD_GET(AL_POS_ERROR_LOG_1_ADDR_HIGH, log1) << 32);
57 request_id = FIELD_GET(AL_POS_ERROR_LOG_1_REQUEST_ID, log1);
58 bresp = FIELD_GET(AL_POS_ERROR_LOG_1_BRESP, log1);
59
60 dev_err(&pdev->dev, "addr=0x%llx request_id=0x%x bresp=0x%x\n",
61 addr, request_id, bresp);
62
63 if (al_pos_panic)
64 panic("POS");
65
66 return IRQ_HANDLED;
67 }
68

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2019-09-09 13:53    [W:0.085 / U:6.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site