lkml.org 
[lkml]   [2019]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH v2 3/3] media: Add support for Cadence CSI2RX 2.1
Hi Jan,

On Mon, Sep 09, 2019 at 09:24:15AM +0000, Jan Kotas wrote:
> >> @@ -439,6 +535,9 @@ static int csi2rx_probe(struct platform_device *pdev)
> >> csi2rx->dev = &pdev->dev;
> >> mutex_init(&csi2rx->lock);
> >>
> >> + of_id = of_match_node(csi2rx_of_table, pdev->dev.of_node);
> >> + csi2rx->vops = (struct csi2rx_vops *)of_id->data;
> >
> > The cast isn't needed, is it?
>
> It’s not, but doesn’t make it more readable?

If there's no need for it, please don't use explicit cast.

--
Sakari Ailus

\
 
 \ /
  Last update: 2019-09-09 11:43    [W:0.035 / U:7.696 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site