lkml.org 
[lkml]   [2019]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subjectdrivers/video/fbdev/vt8500lcdfb.c:229:6: warning: this statement may fall through
tree:   https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux.git master
head: f74c2bb98776e2de508f4d607cd519873065118e
commit: a035d552a93bb9ef6048733bb9f2a0dc857ff869 Makefile: Globally enable fall-through warning
date: 6 weeks ago
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout a035d552a93bb9ef6048733bb9f2a0dc857ff869
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=arm

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

drivers/video/fbdev/vt8500lcdfb.c: In function 'vt8500lcd_blank':
>> drivers/video/fbdev/vt8500lcdfb.c:229:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (info->fix.visual == FB_VISUAL_PSEUDOCOLOR ||
^
drivers/video/fbdev/vt8500lcdfb.c:233:2: note: here
case FB_BLANK_UNBLANK:
^~~~

vim +229 drivers/video/fbdev/vt8500lcdfb.c

d6ff7d0fe22cdf drivers/video/vt8500lcdfb.c Alexey Charkov 2010-11-09 213
e41f1a98940824 drivers/video/vt8500lcdfb.c Alexey Charkov 2011-01-12 214 /*
e41f1a98940824 drivers/video/vt8500lcdfb.c Alexey Charkov 2011-01-12 215 * vt8500lcd_blank():
e41f1a98940824 drivers/video/vt8500lcdfb.c Alexey Charkov 2011-01-12 216 * Blank the display by setting all palette values to zero. Note,
e41f1a98940824 drivers/video/vt8500lcdfb.c Alexey Charkov 2011-01-12 217 * True Color modes do not really use the palette, so this will not
e41f1a98940824 drivers/video/vt8500lcdfb.c Alexey Charkov 2011-01-12 218 * blank the display in all modes.
e41f1a98940824 drivers/video/vt8500lcdfb.c Alexey Charkov 2011-01-12 219 */
e41f1a98940824 drivers/video/vt8500lcdfb.c Alexey Charkov 2011-01-12 220 static int vt8500lcd_blank(int blank, struct fb_info *info)
e41f1a98940824 drivers/video/vt8500lcdfb.c Alexey Charkov 2011-01-12 221 {
e41f1a98940824 drivers/video/vt8500lcdfb.c Alexey Charkov 2011-01-12 222 int i;
e41f1a98940824 drivers/video/vt8500lcdfb.c Alexey Charkov 2011-01-12 223
e41f1a98940824 drivers/video/vt8500lcdfb.c Alexey Charkov 2011-01-12 224 switch (blank) {
e41f1a98940824 drivers/video/vt8500lcdfb.c Alexey Charkov 2011-01-12 225 case FB_BLANK_POWERDOWN:
e41f1a98940824 drivers/video/vt8500lcdfb.c Alexey Charkov 2011-01-12 226 case FB_BLANK_VSYNC_SUSPEND:
e41f1a98940824 drivers/video/vt8500lcdfb.c Alexey Charkov 2011-01-12 227 case FB_BLANK_HSYNC_SUSPEND:
e41f1a98940824 drivers/video/vt8500lcdfb.c Alexey Charkov 2011-01-12 228 case FB_BLANK_NORMAL:
e41f1a98940824 drivers/video/vt8500lcdfb.c Alexey Charkov 2011-01-12 @229 if (info->fix.visual == FB_VISUAL_PSEUDOCOLOR ||
e41f1a98940824 drivers/video/vt8500lcdfb.c Alexey Charkov 2011-01-12 230 info->fix.visual == FB_VISUAL_STATIC_PSEUDOCOLOR)
e41f1a98940824 drivers/video/vt8500lcdfb.c Alexey Charkov 2011-01-12 231 for (i = 0; i < 256; i++)
e41f1a98940824 drivers/video/vt8500lcdfb.c Alexey Charkov 2011-01-12 232 vt8500lcd_setcolreg(i, 0, 0, 0, 0, info);
e41f1a98940824 drivers/video/vt8500lcdfb.c Alexey Charkov 2011-01-12 233 case FB_BLANK_UNBLANK:
e41f1a98940824 drivers/video/vt8500lcdfb.c Alexey Charkov 2011-01-12 234 if (info->fix.visual == FB_VISUAL_PSEUDOCOLOR ||
e41f1a98940824 drivers/video/vt8500lcdfb.c Alexey Charkov 2011-01-12 235 info->fix.visual == FB_VISUAL_STATIC_PSEUDOCOLOR)
e41f1a98940824 drivers/video/vt8500lcdfb.c Alexey Charkov 2011-01-12 236 fb_set_cmap(&info->cmap, info);
e41f1a98940824 drivers/video/vt8500lcdfb.c Alexey Charkov 2011-01-12 237 }
e41f1a98940824 drivers/video/vt8500lcdfb.c Alexey Charkov 2011-01-12 238 return 0;
e41f1a98940824 drivers/video/vt8500lcdfb.c Alexey Charkov 2011-01-12 239 }
e41f1a98940824 drivers/video/vt8500lcdfb.c Alexey Charkov 2011-01-12 240

:::::: The code at line 229 was first introduced by commit
:::::: e41f1a98940824ad0c95271e69939acdc6092e5f fbdev: Implement simple blanking in pseudocolor modes for vt8500lcdfb

:::::: TO: Alexey Charkov <alchark@gmail.com>
:::::: CC: Paul Mundt <lethal@linux-sh.org>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2019-09-09 10:30    [W:0.040 / U:9.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site