lkml.org 
[lkml]   [2019]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] riscv: move sifive_l2_cache.c to drivers/soc
One other comment on this patch:

On Fri, 6 Sep 2019, Paul Walmsley wrote:

> On Sun, 18 Aug 2019, Christoph Hellwig wrote:
>
> > diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
> > index 200c04ce5b0e..9241b3e7a050 100644
> > --- a/drivers/edac/Kconfig
> > +++ b/drivers/edac/Kconfig
> > @@ -462,7 +462,7 @@ config EDAC_ALTERA_SDMMC
> >
> > config EDAC_SIFIVE
> > bool "Sifive platform EDAC driver"
> > - depends on EDAC=y && RISCV
> > + depends on EDAC=y && SIFIVE_L2

Since the guidance from the EDAC maintainers is that this driver is to be
a platform driver -- which would, for example, also include EDAC support for
other IP blocks (e.g., DRAM controllers) on SiFive SoCs -- this should
depend on SOC_SIFIVE, not SIFIVE_L2.


- Paul

\
 
 \ /
  Last update: 2019-09-07 00:36    [W:0.100 / U:7.944 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site