[lkml]   [2019]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] pinctrl: intel: hide unused intel_pin_to_gpio
On Fri, Sep 06, 2019 at 05:26:01PM +0200, Arnd Bergmann wrote:
> The intel_pin_to_gpio() function is only called by the
> PM support functions and causes a warning when those are disabled:
> drivers/pinctrl/intel/pinctrl-intel.c:841:12: error: unused function 'intel_pin_to_gpio' [-Werror,-Wunused-function]
> As we cannot change the PM functions themselves to use __maybe_unused,
> add another #ifdef here for consistency.

It's not adding another #ifdef here...

Nevertheless, I'm afraid that in the future we might need this in other
place(s). Can we add __maybe_unused to this function exclusively?

With Best Regards,
Andy Shevchenko

 \ /
  Last update: 2019-09-06 19:01    [W:0.029 / U:20.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site