Messages in this thread |  | | Subject | Re: [PATCH] kunit: add PRINTK dependency | From | Shuah Khan <> | Date | Fri, 6 Sep 2019 09:39:51 -0600 |
| |
On 9/6/19 9:27 AM, Arnd Bergmann wrote: > The vprintk_emit() function is not available when CONFIG_PRINTK > is disabled: > > kunit/test.c:22:9: error: implicit declaration of function 'vprintk_emit' [-Werror,-Wimplicit-function-declaration] > > I suppose without printk(), there is not much use in kunit > either, so add a Kconfig depenedency here. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > kunit/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kunit/Kconfig b/kunit/Kconfig > index 8541ef95b65a..e80d8af00454 100644 > --- a/kunit/Kconfig > +++ b/kunit/Kconfig > @@ -6,6 +6,7 @@ menu "KUnit support" > > config KUNIT > bool "Enable support for unit tests (KUnit)" > + depends on PRINTK > help > Enables support for kernel unit tests (KUnit), a lightweight unit > testing and mocking framework for the Linux kernel. These tests are >
Hi Arnd,
This is found and fixed already. I am just about to apply Berndan's patch that fixes this dependency. All of this vprintk_emit() stuff is redone.
thanks, -- Shuah
|  |