lkml.org 
[lkml]   [2019]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] lz4: make LZ4HC_setExternalDict as non-static
Date
kbuild warns for exported static symbols. This one seems to
be meant as an external API but does not have any in-kernel
users:

WARNING: "LZ4HC_setExternalDict" [vmlinux] is a static EXPORT_SYMBOL

I suppose the function should not just get removed since it would
be nice to stay close to the upstream version of lz4hc, so just
make it global.

The modpost commit is correct, but is listed here as the one
that introduced the warning.

Fixes: 15bfc2348d54 ("modpost: check for static EXPORT_SYMBOL* functions")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
lib/lz4/lz4hc_compress.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/lz4/lz4hc_compress.c b/lib/lz4/lz4hc_compress.c
index 176f03b83e56..e1075293c009 100644
--- a/lib/lz4/lz4hc_compress.c
+++ b/lib/lz4/lz4hc_compress.c
@@ -642,7 +642,7 @@ EXPORT_SYMBOL(LZ4_loadDictHC);

/* compression */

-static void LZ4HC_setExternalDict(
+void LZ4HC_setExternalDict(
LZ4HC_CCtx_internal *ctxPtr,
const BYTE *newBlock)
{
--
2.20.0
\
 
 \ /
  Last update: 2019-09-06 17:37    [W:0.036 / U:0.484 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site