lkml.org 
[lkml]   [2019]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] 9p: make two arrays static const, makes object smaller
Colin King wrote on Fri, Sep 06, 2019:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the arrays on the stack but instead make them
> static const. Makes the object code smaller by 386 bytes.
>
> Before:
> text data bss dec hex filename
> 17443 2076 0 19519 4c3f fs/9p/vfs_inode_dotl.o
>
> After:
> text data bss dec hex filename
> 16897 2236 0 19133 4abd fs/9p/vfs_inode_dotl.o
>
> (gcc version 9.2.1, amd64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Fine with me, I'll pick it up for the next cycle.

There are a couple of static structs in net/9p that aren't const (but
could be); I guess the static is all that matters here?
(I'll try to go through and make the rest const when I have time
though, no harm there)

Thanks,
--
Dominique

\
 
 \ /
  Last update: 2019-09-06 16:02    [W:0.031 / U:14.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site