lkml.org 
[lkml]   [2019]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] scsi: virtio_scsi: unplug LUNs when events missed
On Thu, Sep 05, 2019 at 06:19:28PM +0000, Matt Lupfer wrote:
> The event handler calls scsi_scan_host() when events are missed, which
> will hotplug new LUNs. However, this function won't remove any
> unplugged LUNs. The result is that hotunplug doesn't work properly when
> the number of unplugged LUNs exceeds the event queue size (currently 8).
>
> Scan existing LUNs when events are missed to check if they are still
> present. If not, remove them.
>
> Signed-off-by: Matt Lupfer <mlupfer@ddn.com>
> ---
> drivers/scsi/virtio_scsi.c | 33 +++++++++++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)

Please include a changelog in future patch revisions. For example:

Signed-off-by: ...
---
v2:
* Replaced magic constants with sd.h constants [Michael]

Just C and virtio code review, no SCSI specifics:

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-09-06 10:55    [W:0.030 / U:9.984 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site