lkml.org 
[lkml]   [2019]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 net-next] net: stmmac: Add support for MDIO interrupts
> 
> The change log is near the end of the patch:
> /**
> --
> Changelog v2
> *mdio interrupt mode or polling mode will depends on mdio interrupt enable bit
> *Disable the mdio interrupt enable bit in stmmac_release
> *Remove the condition for initialize wait queues
> *Applied reverse Christmas tree
> 1.9.1

At the end, nobody sees it, because everybody else does it at the beginning.

https://www.kernel.org/doc/html/latest/process/submitting-patches.html?highlight=submitting#the-canonical-patch-format

This talks about the ---. David prefers to see the change log before
the ---. Other maintainers want it after the ---.

>
> >
> > The formatting of this patch also looks a bit odd. Did you use git
> > format-patch ; git send-email?
>
> Yes, I do git format-patch, then ./scripts/checkpatch.pl.
> Lastly git send-email

What looked odd is the missing --- marker. git format-patch should of
create that as part of the patch.

Andrew

\
 
 \ /
  Last update: 2019-09-05 08:40    [W:0.069 / U:5.884 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site